Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpuv::service(timeoutMs)
takes time in milliseconds. The first two parameters (maxTimeout
andtimerCallback$timeToNextEvent()
) are in ms, the finallater::next_op_secs
is in seconds.With the mismatched units the
min()
call would've resulted in a very small value (because of thelater
argument being in seconds), leading to short timeouts, possibly increasing unnecessary polling (and perhaps higher-than-needed CPU usage?).