Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soft-deprecate bootstrapPage() and basicPage() #2595

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

cpsievert
Copy link
Collaborator

Fixes #2863

@jcheng5
Copy link
Member

jcheng5 commented Sep 13, 2019

I actually think we should leave bootstrapPage alone, it's a useful building block if you want e.g. multiple containers in a page (one example is full-bleed images in the middle of an app).

basicPage is probably useless now, I think it had a purpose in the bs2 era. But I'd rather not add soft-deprecation at the end of a release cycle, so let's move forward with that right after we ship 1.4.

@hadley
Copy link
Member

hadley commented Sep 13, 2019

@jcheng5 I think it's low risk to add soft deprecation, even at the end of a release cycle, because it doesn't actually change behaviour (just documentation).

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2019

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide bootstrapPage docs
4 participants