Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review checks in composed/signed_key/public #383

Open
hko-s opened this issue Aug 10, 2024 · 0 comments
Open

Review checks in composed/signed_key/public #383

hko-s opened this issue Aug 10, 2024 · 0 comments

Comments

@hko-s
Copy link
Contributor

hko-s commented Aug 10, 2024

E.g. in

rpgp/src/composed/signed_key/public.rs

Lines 85 to 92 in 017be15

public_subkeys.retain(|key| {
if key.signatures.is_empty() {
warn!("ignoring unsigned {:?}", key.key);
false
} else {
true
}
});
the presence of signatures is taken as a signal for subkey (in)validity. However, I think the signatures have not been cryptographically verified at that point.

Whatever amount of checking and filtering is done in that module, it might be surprising to some users. We should probably decide (and document) what semantics the signed_key module aims for. (I don't have a concrete suggestion, for now, but I hope to arrive at one, some day 😅)
@hko-s hko-s mentioned this issue Aug 10, 2024
Merged
hko-s added a commit to hko-s/rpgp that referenced this issue Aug 10, 2024
@hko-s
moved personal note to rpgp#383
84e2d49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hko-s