Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InternalDeprecatedCOSCloner causing JPMS module issues #56

Closed
pjfanning opened this issue Aug 21, 2023 · 3 comments
Closed

InternalDeprecatedCOSCloner causing JPMS module issues #56

pjfanning opened this issue Aug 21, 2023 · 3 comments

Comments

@pjfanning
Copy link

Thanks for the 3.0.0 release. I tried building Apache POI with PDFBox and this lib upgraded to 3.0.0 but the JPMS module-info compile fails in POI. I am no expert in JPMS but I think it is because of the fact that you have a org.apache.pdfbox.multipdf class (InternalDeprecatedCOSCloner). JPMS builds are stricter about packages and generally require that a package is only part of 1 jar and that you don't have 2 jars that have classes in the same package.

The errors look like:

/Users/pj.fanning/svn/poi/poi-ooxml/src/main/java9/module-info.java:18: error: module org.apache.poi.ooxml reads package org.apache.pdfbox.multipdf from both de.rototor.pdfbox.graphics2d and org.apache.pdfbox
@rototor
Copy link
Owner

rototor commented Aug 21, 2023

I've reopened PDFBOX-5149, please look there for details. This project is not really prepared for JPMS yet...

@rototor
Copy link
Owner

rototor commented Aug 22, 2023

The PDFBox folks don't want issues to reopened, so I create a new one: https://issues.apache.org/jira/browse/PDFBOX-5664

@rototor
Copy link
Owner

rototor commented Dec 3, 2023

PDFBox 3.0.1 was now released with the fix for PDFBOX-5664. I've made the needed adjustments and release PDFBox-Graphics version 3.0.1 - or at least I tried. I think the release should be now on maven central - but the oss.sonatype.org nexus has some at the moment... so the mvn perform:release reported some error. But as far as I understand the release with through.

So you can try with JPMS again, should work now.

@rototor rototor closed this as completed Dec 3, 2023
@carlosame carlosame mentioned this issue Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rototor @pjfanning