Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update text-field model types to fix a build error #8635

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Sep 26, 2024

Closes #(issue_number)

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

Copy link
Contributor

@cleanerzkp cleanerzkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.57%. Comparing base (5aa07f1) to head (862aabd).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
...rontend/app/src/components/notes/UserNotesForm.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8635       /-   ##
===========================================
- Coverage    58.58%   58.57%   -0.02%     
===========================================
  Files         1790     1790              
  Lines       124742   124649      -93     
  Branches     16266    16245      -21     
===========================================
- Hits         73085    73014      -71     
  Misses       49050    49033      -17     
  Partials      2607     2602       -5     
Flag Coverage Δ
frontend_integration 56.55% <66.66%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelsos kelsos merged commit 3a024fd into rotki:develop Sep 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants