Temporary fix for Eigenlayer validators exit/exiting #8415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bugfixes #8415 /- ##
============================================
- Coverage 53.80% 53.79% -0.02%
============================================
Files 1710 1711 1
Lines 168970 169011 41
Branches 13989 13999 10
============================================
Hits 90919 90922 3
- Misses 75630 75645 15
- Partials 2421 2444 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is the bugfixes part of rotki#8397. Essentially we no longer rely on history events processing to detect a validator has exited. That is due to the fact we may track a validator but not its exit event due to not tracking the withdrawal address directly. This happens for example in Eigenlayer native restaking. This temporary fix is a hack considering that if "enough time" has passed since the exit was started (the time of withdrawable_ts) and now then we consider it exited. Long term solution will happen in develop/1.35.0 as per the issue description Signed-off-by: Lefteris Karapetsas <[email protected]>
LefterisJP
force-pushed
the
8397_bugfixes
branch
from
e0624c2
to
625a438
Compare
|
Pushed some test fixes/adjustment. Even had to skip one due to not making sense to adjust and it being too complicated. They would need to be retouched in develop. And at least 2 of them re-recorded. |
|
okay all green. But need to handle the skipped/adustes tests in develop. |
LefterisJP
temporarily deployed
to
cassette-merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the bugfixes part of #8397.
Essentially we no longer rely on history events processing to detect a validator has exited. That is due to the fact we may track a validator but not its exit event due to not tracking the withdrawal address directly. This happens for example in Eigenlayer native restaking.
This temporary fix is a hack considering that if "enough time" has passed since the exit was started (the time of withdrawable_ts) and now then we consider it exited.
Long term solution will happen in develop/1.35.0 as per the issue description