Fix issue creating many snapshots #8392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bugfixes #8392 /- ##
============================================
- Coverage 53.80% 51.94% -1.87%
============================================
Files 1710 1710
Lines 168970 168983 13
Branches 13989 13992 3
============================================
- Hits 90919 87773 -3146
- Misses 75630 79022 3392
Partials 2421 2188 -233
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LefterisJP
approved these changes
Aug 12, 2024
| @pytest.mark.parametrize('number_of_eth_accounts', [0]) | ||
| def test_snapshots_dont_happen_always(rotkehlchen_api_server: 'APIServer') -> None: | ||
| """Regression test for an issue we had where the task for snapshots was | ||
| creating one for each run of the background task. |
There was a problem hiding this comment.
Suggested change
| creating one for each run of the background task. | |
| creating a snapshot for each run of the background task. |
LefterisJP
temporarily deployed
to
cassette-merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #(issue_number)
Checklist