Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): allow filtering by event_subtype directly #8376

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix(frontend): allow filtering by event_subtype directly #8376

merged 1 commit into from
Aug 8, 2024

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 53.81%. Comparing base (40bd27d) to head (3d3967a).
Report is 2 commits behind head on bugfixes.

Files Patch % Lines
frontend/app/src/composables/filters/events.ts 44.44% 15 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           bugfixes    #8376    /-   ##
=========================================
  Coverage     53.80%   53.81%           
=========================================
  Files          1710     1710           
  Lines        168970   169067    97     
  Branches      13989    14000    11     
=========================================
  Hits          90919    90985    66     
- Misses        75630    75661    31     
  Partials       2421     2421
Flag Coverage Δ
frontend_integration 60.42% <ø> ( 0.59%) ⬆️
frontend_unit 38.72% <46.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kelsos
kelsos approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kelsos kelsos merged commit 02d39a1 into rotki:bugfixes Aug 8, 2024
15 checks passed
@kelsos kelsos deleted the filter-by-subtype branch August 8, 2024 10:15
OjusWiZard pushed a commit to OjusWiZard/rotki that referenced this pull request Aug 9, 2024
@lukicenturi @OjusWiZard
fix(frontend): allow filtering by event_subtype directly (rotki#8376)
638ded6
OjusWiZard pushed a commit to OjusWiZard/rotki that referenced this pull request Aug 9, 2024
@lukicenturi @OjusWiZard
fix(frontend): allow filtering by event_subtype directly (rotki#8376)
da337a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelsos kelsos kelsos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukicenturi @kelsos