Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix dynamic message margin #8374

Merged
merged 1 commit into from
Aug 8, 2024
Merged

style: fix dynamic message margin #8374

merged 1 commit into from
Aug 8, 2024

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Aug 7, 2024

Closes #(issue_number)

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

@kelsos kelsos requested a review from lukicenturi August 7, 2024 17:17
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.74%. Comparing base (b20992a) to head (ea9ecf3).
Report is 3 commits behind head on develop.

Files Patch % Lines
frontend/app/src/pages/dashboard/index.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8374       /-   ##
===========================================
- Coverage    59.24%   57.74%   -1.50%     
===========================================
  Files         1742     1757       15     
  Lines       124408   124516      108     
  Branches     16596    16241     -355     
===========================================
- Hits         73702    71899    -1803     
- Misses       48256    50167     1911     
  Partials      2450     2450              
Flag Coverage Δ
frontend_integration 56.65% <ø> ( 4.56%) ⬆️
frontend_unit 31.22% <0.00%> (-5.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lukicenturi lukicenturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukicenturi lukicenturi merged commit ea25361 into rotki:develop Aug 8, 2024
15 checks passed
@kelsos kelsos deleted the cta branch August 8, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants