Add payment/grant event subtypes and event categories #8371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bugfixes #8371 /- ##
============================================
Coverage 53.79% 53.80% 0.01%
============================================
Files 1710 1710
Lines 168973 168970 -3
Branches 13990 13989 -1
============================================
Hits 90901 90919 18
Misses 75645 75630 -15
Partials 2427 2421 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yabirgb
reviewed
Aug 7, 2024
Comment on lines
36
to
37
| HistoryEventSubType.PAYMENT: EventCategory.RECEIVE_PAYMENT, | ||
| HistoryEventSubType.GRANT: EventCategory.RECEIVE_GRANT, |
There was a problem hiding this comment.
where are those 2 defined? I don't see them in bugfixes
There was a problem hiding this comment.
In this PR. But one mapping is missing which I will push.
Signed-off-by: Lefteris Karapetsas <[email protected]>
LefterisJP
force-pushed
the
add_payment_and_grant
branch
from
e43333f
to
40bd27d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.