Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): breakdown for eth from staking not showing #8367

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix(frontend): breakdown for eth from staking not showing #8367

merged 1 commit into from
Aug 7, 2024

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 26.47059% with 25 lines in your changes missing coverage. Please review.

Project coverage is 53.78%. Comparing base (5e2b095) to head (a944390).
Report is 5 commits behind head on bugfixes.

Files Patch % Lines
frontend/app/src/store/blockchain/index.ts 14.28% 12 Missing ⚠️
frontend/app/src/composables/assets/retrieval.ts 31.25% 11 Missing ⚠️
...p/src/components/dashboard/DashboardAssetTable.vue 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           bugfixes    #8367       /-   ##
============================================
- Coverage     53.79%   53.78%   -0.02%     
============================================
  Files          1710     1710              
  Lines        168973   169036       63     
  Branches      13990    13994        4     
============================================
  Hits          90901    90910        9     
- Misses        75645    75699       54     
  Partials       2427     2427
Flag Coverage Δ
frontend_integration 59.74% <12.50%> (-0.06%) ⬇️
frontend_unit 38.71% <26.47%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LefterisJP
LefterisJP reviewed Aug 7, 2024
View reviewed changes
docs/changelog.rst Outdated Show resolved Hide resolved
@kelsos kelsos merged commit f9dc6ce into rotki:bugfixes Aug 7, 2024
15 checks passed
@kelsos kelsos deleted the eth-breakdown-for-eth2 branch August 7, 2024 13:58
OjusWiZard pushed a commit to OjusWiZard/rotki that referenced this pull request Aug 9, 2024
@lukicenturi @OjusWiZard
fix(frontend): breakdown for eth from staking not showing (rotki#8367)
541b542
OjusWiZard pushed a commit to OjusWiZard/rotki that referenced this pull request Aug 9, 2024
@lukicenturi @OjusWiZard
fix(frontend): breakdown for eth from staking not showing (rotki#8367)
8d157d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LefterisJP LefterisJP LefterisJP left review comments

@kelsos kelsos kelsos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukicenturi @LefterisJP @kelsos