fix: show balances loading from beginning #8358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bugfixes #8358 /- ##
============================================
- Coverage 53.77% 53.76% -0.01%
============================================
Files 1708 1708
Lines 168799 168821 22
Branches 13951 13952 1
============================================
Hits 90769 90769
- Misses 75611 75633 22
Partials 2419 2419
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kelsos
reviewed
Aug 5, 2024
lukicenturi
force-pushed
the
show-balances-loading-from-beginning
branch
from
a4e5448
to
23958e7
Compare
lukicenturi
commented
Aug 5, 2024
| @@ -87,7 87,7 @@ export const useStatusStore = defineStore('status', () => { | |||
| const shouldShowLoadingScreen = (section: Section, subsection: string = defaultSection) => computed<boolean>(() => { | |||
| const statuses = get(status)[section]; | |||
| if (!statuses) | |||
| return false; | |||
| return true; | |||
There was a problem hiding this comment.
this one should be true, because if it's not found, it means the status is None, hence it should be true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show loading for dashboard percentage and chart from beginning, to not show sudden decrease when balances is not loaded