Avoid recursion error in inquirer #8341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bugfixes #8341 /- ##
============================================
Coverage 53.80% 53.81% 0.01%
============================================
Files 1707 1708 1
Lines 168704 168797 93
Branches 13956 13980 24
============================================
Hits 90774 90846 72
- Misses 75505 75526 21
Partials 2425 2425
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yabirgb
added
the
ready for final review
LefterisJP
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Some comments but also I would suggest catching somewhere in the root of the function callls the possible exceptions and logging an error and exiting gracefully there too.
So catch RecursionError and then perhaps the other ones that were raised during our tests?
rotkehlchen/inquirer.py
Outdated
| ): | ||
| Inquirer._msg_aggregator.add_error( | ||
| f'Token {asset} has itself as underlying token. Please edit the ' | ||
| 'asset to fix it.', |
There was a problem hiding this comment.
Suggested change
| 'asset to fix it.', | |
| 'asset to fix it. Price queries will not work until this is done.', |
yabirgb
force-pushed
the
inquirer
branch
2 times, most recently
from
d053cd2
to
65adad2
Compare
LefterisJP
reviewed
Jul 29, 2024
yabirgb
force-pushed
the
inquirer
branch
4 times, most recently
from
e44edc4
to
06b1dd6
Compare
LefterisJP
reviewed
Jul 29, 2024
yabirgb
force-pushed
the
inquirer
branch
5 times, most recently
from
652c0cf
to
074c1ea
Compare
LefterisJP
reviewed
Jul 30, 2024
LefterisJP
temporarily deployed
to
cassette-merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8169
Checklist