Use some perflint checks to improve performance #8336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool is a nice idea but it's overwhelming with way too many false positives. Some rules also are probably an overkill. Like the import full method and not just module and then do the .method always. Though they do make sense it's a lot of work to adjust and maybe too anal. Let's see. Signed-off-by: Lefteris Karapetsas <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8336 /- ##
===========================================
- Coverage 54.84% 54.65% -0.19%
===========================================
Files 1744 1744
Lines 125001 124994 -7
Branches 16613 16613
===========================================
- Hits 68551 68317 -234
- Misses 54133 54335 202
- Partials 2317 2342 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
all green |
LefterisJP
temporarily deployed
to
cassette-merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool is a nice idea but it's overwhelming with way too many false positives.
Some rules also are probably an overkill. Like the import full method and not just module and then do the .method always. Though they do make sense it's a lot of work to adjust and maybe too anal.
Let's see.