Split tests in CI #8319
Merged
Split tests in CI #8319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yabirgb
force-pushed
the
mk8
branch
4 times, most recently
from
fb8a1eb
to
3a014d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8319 /- ##
===========================================
Coverage 51.56% 54.66% 3.10%
===========================================
Files 1728 1729 1
Lines 124855 124816 -39
Branches 16561 16562 1
===========================================
Hits 64384 68234 3850
Misses 58458 54256 -4202
- Partials 2013 2326 313
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yabirgb
added
the
ready for final review
LefterisJP
reviewed
Jul 24, 2024
rotkehlchen/tests/fixtures/db.py
Outdated
| """Create and return the user data directory. Clean up old directory if existing""" | ||
| user_data_dir = data_dir / USERSDIR_NAME / username | ||
| if worker_id != 'master': |
There was a problem hiding this comment.
same here. Would need a comment to explain why this is here and what it does. Best in the docstring.
yabirgb
force-pushed
the
mk8
branch
2 times, most recently
from
d799dc9
to
8b3cc63
Compare
LefterisJP
temporarily deployed
to
cassette-merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #(issue_number)
Checklist