Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show proper confirmation message on account delete #8310

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: show proper confirmation message on account delete #8310

merged 1 commit into from
Jul 23, 2024

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Jul 23, 2024

Closes #(issue_number)

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.73%. Comparing base (e016329) to head (5ec85b5).

Files Patch % Lines
...posables/accounts/blockchain/use-account-delete.ts 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8310       /-   ##
===========================================
  Coverage    51.58%   51.73%    0.14%     
===========================================
  Files         1728     1726       -2     
  Lines       124856   125312      456     
  Branches     16561    16034     -527     
===========================================
  Hits         64413    64832      419     
- Misses       58431    58468       37     
  Partials      2012     2012
Flag Coverage Δ
frontend_integration 56.60% <100.00%> (-0.30%) ⬇️
frontend_unit 37.05% <0.00%> ( 0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lukicenturi
lukicenturi approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@lukicenturi lukicenturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukicenturi lukicenturi merged commit fb65c44 into rotki:develop Jul 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukicenturi lukicenturi lukicenturi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelsos @lukicenturi