Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): add coingecko and cryptocompare to asset mapping endpoint #8296

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

lukicenturi
Copy link
Contributor

@lukicenturi lukicenturi commented Jul 19, 2024

Backend part of #4457

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

@lukicenturi lukicenturi force-pushed the backend-for-asset-mapping branch 3 times, most recently from 272fd19 to 0f72f50 Compare July 19, 2024 06:39
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.26%. Comparing base (95e8b95) to head (4663631).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8296       /-   ##
===========================================
  Coverage    50.93%   59.26%    8.33%     
===========================================
  Files         1723     1723              
  Lines       124861   124865        4     
  Branches     16498    16500        2     
===========================================
  Hits         63592    74006    10414     
  Misses       59257    48412   -10845     
- Partials      2012     2447      435     
Flag Coverage Δ
backend 80.89% <100.00%> ( 18.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukicenturi lukicenturi requested a review from a team July 19, 2024 08:14
Copy link
Member

@LefterisJP LefterisJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LefterisJP LefterisJP merged commit 01713a4 into rotki:develop Jul 19, 2024
14 checks passed
@LefterisJP LefterisJP deleted the backend-for-asset-mapping branch July 19, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants