Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch from loglevel to consola for frontend logging #8290

Merged
merged 1 commit into from
Jul 18, 2024
Merged

chore: switch from loglevel to consola for frontend logging #8290

merged 1 commit into from
Jul 18, 2024

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Jul 18, 2024

Closes #(issue_number)

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

@kelsos kelsos requested a review from lukicenturi July 18, 2024 13:25
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.54902% with 14 lines in your changes missing coverage. Please review.

Project coverage is 60.18%. Comparing base (60497e1) to head (ffa04eb).
Report is 4 commits behind head on develop.

Files Patch % Lines
frontend/app/src/utils/logging.ts 66.66% 14 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8290       /-   ##
===========================================
  Coverage    60.12%   60.18%    0.05%     
===========================================
  Files         1709     1709              
  Lines       124735   124812       77     
  Branches     16485    18638     -537     
===========================================
  Hits         75003    75116      113     
  Misses       47317    47281      -36     
  Partials      2415     2415
Flag Coverage Δ
frontend_integration 57.50% <75.00%> ( 0.50%) ⬆️
frontend_unit 36.72% <50.98%> ( 0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lukicenturi
lukicenturi approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@lukicenturi lukicenturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lukicenturi lukicenturi merged commit cb9a432 into rotki:develop Jul 18, 2024
15 checks passed
@kelsos kelsos deleted the consola branch July 18, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukicenturi lukicenturi lukicenturi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kelsos @lukicenturi