Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rotki to import addresses from other wallets #8339

Closed
lukicenturi opened this issue Jul 29, 2024 · 0 comments · Fixed by #8481
Closed

Allow rotki to import addresses from other wallets #8339

lukicenturi opened this issue Jul 29, 2024 · 0 comments · Fixed by #8481
Labels
Milestone

Comments

@lukicenturi
Copy link
Contributor

lukicenturi commented Jul 29, 2024

Abstract

Initially, when I tried to fix #8334, I realized we can get all wallets installed in the user browser.

The example is in this PR #8338
In that PR, I tried to check emitted eip6963:announceProvider event, and specifically looking for metamask.
But we can find all available providers, and loop them in the UI, and let user select the provider they want instead.

Useful information:
https://eips.ethereum.org/EIPS/eip-6963
https://docs.metamask.io/wallet/how-to/connect/#connect-to-metamask-using-third-party-libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants