Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX for dialog when adding many multiple addresses #8335

Open
aspiers opened this issue Jul 27, 2024 · 1 comment
Open

UX for dialog when adding many multiple addresses #8335

aspiers opened this issue Jul 27, 2024 · 1 comment
Labels

Comments

@aspiers
Copy link
Collaborator

aspiers commented Jul 27, 2024

Problem Definition

I initiated import of about 20-30 accounts from Metamask in one go (after using the workaround in #8334), with the option to scan multiple EVM chains enabled. Then it just stuck on the modal dialog for adding accounts for a long time (10s of minutes probably), with the spinner going around, and a cancel button as the only obviously available user account. I'm guessing that ~25 accounts multiplied by several EVM chains led to the need for hundreds of API calls.

As I was writing this description, the modal dialog closed by itself, hence the lack of screenshots and slightly fuzzy description above. Now I can use Rotki as normal while the scanning continues in the background, so all is well; but I think the import process needs to account for the possibility that it will take a long time, and immediately start in the background by default rather than making the user choose between waiting indefinitely and clicking the cancel button.

Note: Also happen when many addresses are being added manually.

@lukicenturi
Copy link
Contributor

Generally it's not happen only when user imported addresses through metamask, but also if it done manually. Gonna change the title.

@lukicenturi lukicenturi changed the title Metamask import dialog hangs with no progress feedback UX for dialog when adding many multiple addresses Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants