Force xmlschema < 1.1 for Python 2 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks you for creating this PR. Rather then duplicating all steps please install the dependency in question with a conditional (similar to https://github.com/ros-infrastructure/catkin_pkg/blob/27013d87262bef0d6ac7b9642aa4ed18d9ce21cd/.travis.yml#L14-L15). |
|
Done in 6a4ad53 - Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xmlschema1.1.0 (released Jan 23 2020) dropped support for Python 2. This has been breaking CI builds.Note that I am explicitly listing the two jobs rather than using Travis' matrix expansion as before, so that we can still get up-to-date versions of
xmlschemafor Python 3 builds.If you'd prefer to use the same
xmlschemaversion for both builds, this PR can be simplified to a just adding:<1.1on line 8.