Fix Python Linking on OSX #502
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch was verified in RoboStack where it fixes the segfault. |
|
Ping @tfoote |
MatthijsBurgh
approved these changes
Jun 1, 2022
|
@tfoote friendly ping; Waiting for your approval and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RoboStack/ros-noetic#86 we discovered that
import tf2_pyresults in a segmentation fault on OSX. We previously observed similar issues with cv_bridge: ros-perception/vision_opencv#331 which also contains links to why the proposed solution here works (see pytorch/pytorch@73f6715).