Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: [email protected] & improvements #3128

Merged
merged 12 commits into from
Apr 5, 2023
Merged

bump: [email protected] & improvements #3128

merged 12 commits into from
Apr 5, 2023

Conversation

kellymears
Copy link
Member

@kellymears kellymears commented Mar 22, 2023

  • add: simple comments to jsconfig.json
  • improve: bud.wpjson.set replacing bud.wpjson.settings.
    • bud.wpjson.settings is not deprecated for [email protected]
    • the defaults for bud.wpjson.settings include disabling dropCap, which wasn't in the config before since bud.wpjson.settings fully overrides the defaults. Unless we explicitly set it in the config it will be false (see the theme.json diff).
  • if (import.meta.webpackHot) seems safer than optional chaining, since import.meta.webpackHot isn't a real method. For instance import.meta?.webpackHot? will cause errors, which would be unexpected given our sample code.

todo

  • gotta actually bump to 6.12.0 after release
  • resolve dropCap question one way or the other (see above)

@github-actions github-actions bot added build javascript Pull requests that update Javascript code labels Mar 22, 2023
@retlehs retlehs marked this pull request as ready for review April 5, 2023 16:17
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Apr 5, 2023
@kellymears kellymears merged commit cc94b1b into main Apr 5, 2023
@kellymears kellymears deleted the 6.12.0 branch April 5, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants