Beta 2 #1806

retlehs · 2017-01-11T19:54:05Z

~~this should partially fix #1804. known issue:~~

initial browsersync session is still broken and will return the following message:

Uncaught TypeError: __WEBPACK_IMPORTED_MODULE_2__util_Router__[false] is not a constructor
    at Object.<anonymous> (main.js:23)
    at Object.<anonymous> (main.js:27)
    at __webpack_require__ (bootstrap f2d9dd8…:659)
    at fn (bootstrap f2d9dd8…:83)
    at Object.<anonymous> (tether.js:1811)
    at __webpack_require__ (bootstrap f2d9dd8…:659)
    at bootstrap f2d9dd8…:708
    at bootstrap f2d9dd8…:708

~~error goes away and browsersync should work as expected if you follow these steps:~~

~~1. save a file (make a styling change)~~
~~2. manually refresh your browsersync session~~

~~testing would be appreciated /cc @emilsgulbis @dappa @MWDelaney @psorensen~~

~~edit: this branch has since been updated with other commits, the relevant fix for #1804 is 417ce46~~

edit 2: #1804 is fixed after #1815

#1797

…nano

#1797

MWDelaney · 2017-01-11T20:21:03Z

This fixes the issue for me!

psorensen · 2017-01-11T20:40:37Z

Fix works for me as described by @retlehs.

retlehs · 2017-01-11T21:42:21Z

thank you for testing!

Update clean task name

Allow browser versions to be configured in config.json

retlehs · 2017-01-11T23:09:28Z

@eshimischi thanks for pointing that out. updated

Remove grid defaults

Remove Font Awesome

tobeycodes · 2017-01-13T19:43:43Z

What are your thoughts on being able to always filter the data regardless of the body class? E.g. injecting theme options like social media links

QWp6t · 2017-01-13T21:01:06Z

@schrapel use something like...

sage('blade')->share('links', [
  'facebook' => 'https://facebook.com/myAwesomePage',
  'twitter' => 'https://twitter.com/rootswp',
  // etc..
]);

Then in all views, a $links variable will be available.

@QWp6t

* Add option to remove Bootstrap when creating project * Remove phpmd, per @QWp6t

Add option to change theme file headers

ghost · 2017-01-16T15:29:01Z

Hi,
I was able to fix the issue mentioned at the beginning of this thread and it is really weird.

Downloaded beta-2 (1826102)
cd ~/****/wp-content/themes/name/
php ../composer.phar install (my composer file is in themes/)
yarn upgrade [email protected] to fix the webpack beta 1.9 alert in yarn
edit config.json with devURL = localhost:8888 and publicPath = /wp-content/themes/name
yarn build
yarn run start
At this point the webpack Module 2 error should still be there.
Open assets/scripts/main.js and remove trailing comma after aboutUs.
Save, manually refresh the BrowserSync window and ignore all errors.
Put the comma back (type it, not CTRL Z it)
Save, manually refresh the BrowserSync window.
All should be working perfectly fine. Edit $brand-primary: red for example and it should work.

Hope it helps troubleshooting!

derkjn · 2017-01-17T04:31:04Z

I was testing this today and I noticed that when running the production build, there's something wrong with how the ExtractTextPlugin handles the paths to the fonts.

To recreate the issue, you can simply add <i class="fa fa-cog"></i> to any of your templates and open the page. You'll notice the following error in the console :

This issue is resolved if I remove the publicPath: '../', configuration for css and scss from my webpack.config.js file.
Not sure exactly what's going wrong there but definitely something to look into!

Add option to add Font Awesome

* Add option to select CSS framework, add Foundation as an option

* Update dependencies * Remove monkey-hot-loader * Use webpack-merge instead of util/mergeWithConcat() * Fix: copyglobs plugin `after-emit` is bound twice * NoErrorsPlugin() is deprecated in favor of NoEmitOnErrorsPlugin() * webpack-dev-middleware should use same publicPath as compiler * webpack-hot-middleware/client should be prepended to entries * Browser should refresh when HMR fails * Bootstrap package.json has correct main property Sometime between alpha 2 and 3, package.json was pointing to nonexistent file, so we referenced file manually in our repo. Underlying issue was fixed by alpha 4, so we no longer have to specify full path to file.

retlehs · 2017-01-24T01:08:47Z

@derkjn unable to reproduce. please post on https://discourse.roots.io/ if you need further support

derkjn · 2017-01-24T02:40:02Z

@retlehs Thanks for replying, this got fixed with #1815 . Thank you!

oxyc and others added 6 commits January 10, 2017 13:03

Allow autoprefixer's browser versions to be configured

6b37080

rename clean task

7d87c3d

#1797

Update README to include new task name

faf77d7

#1797

Respect autoprefixer browsers when stripping vendor prefixes with css…

f4cf20b

…nano

Update travis

eff6644

#1797

Fix for publicPath

417ce46

retlehs added 3 commits January 11, 2017 16:01

Merge pull request #1800 from psorensen/issue/1797

21c6d66

Update clean task name

Merge pull request #1798 from oxyc/patch-1

d954213

Allow browser versions to be configured in config.json

Use NoEmitOnErrorsPlugin, thanks @eshimischi

1279552

retlehs added 2 commits January 11, 2017 16:12

Update CHANGELOG, bump version [ci skip]

7a3e792

Revert to yarn.lock from master, previous Webpack RC

8bd55bb

retlehs mentioned this pull request Jan 12, 2017

[Bug] Beta 1: Problems with watcher (SCSS & PHP) #1804

Closed

6 tasks

retlehs added 6 commits January 13, 2017 11:22

Remove outdated browser warning

9fca64a

Remove grid defaults

646c636

Merge pull request #1808 from roots/remove-grid-defaults

596f66f

Remove grid defaults

Remove Font Awesome

865ade5

Update CHANGELOG [ci skip]

66b70b6

Merge pull request #1809 from roots/remove-font-awesome

ea7323a

Remove Font Awesome

retlehs added 5 commits January 14, 2017 19:56

Add option to remove Bootstrap when creating project (#1810)

b91ab89

* Add option to remove Bootstrap when creating project * Remove phpmd, per @QWp6t

Missed in #1809

70328d9

Add option to change theme file headers

c2c43df

Update README, CHANGELOG [ci skip]

5b5d362

Merge pull request #1811 from roots/option-to-change-theme-file-headers

1826102

Add option to change theme file headers

retlehs and others added 6 commits January 17, 2017 14:59

Add option to add Font Awesome

1f8f24f

Merge pull request #1812 from roots/option-to-add-font-awesome

89b4d1c

Add option to add Font Awesome

Add option to select CSS framework, add Foundation as an option (#1813)

3909bf7

* Add option to select CSS framework, add Foundation as an option

Fix Bootstrap JS removal/replacement

360dfc9

Update CHANGELOG [ci skip]

c63d155

retlehs merged commit 9ebe9cd into master Jan 19, 2017

retlehs deleted the beta2 branch January 19, 2017 16:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Beta 2 #1806

Beta 2 #1806

retlehs commented Jan 11, 2017 •

edited

Loading

MWDelaney commented Jan 11, 2017

psorensen commented Jan 11, 2017

retlehs commented Jan 11, 2017

retlehs commented Jan 11, 2017

tobeycodes commented Jan 13, 2017

QWp6t commented Jan 13, 2017

ghost commented Jan 16, 2017

derkjn commented Jan 17, 2017

retlehs commented Jan 24, 2017

derkjn commented Jan 24, 2017

Beta 2 #1806

Beta 2 #1806

Conversation

retlehs commented Jan 11, 2017 • edited Loading

MWDelaney commented Jan 11, 2017

psorensen commented Jan 11, 2017

retlehs commented Jan 11, 2017

retlehs commented Jan 11, 2017

tobeycodes commented Jan 13, 2017

QWp6t commented Jan 13, 2017

ghost commented Jan 16, 2017

derkjn commented Jan 17, 2017

retlehs commented Jan 24, 2017

derkjn commented Jan 24, 2017

retlehs commented Jan 11, 2017 •

edited

Loading