Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rook discards Mgr SeviceMonitor monitoring labels when active manager reelected #14477

Closed
arttor opened this issue Jul 22, 2024 · 0 comments · Fixed by #14482
Closed

Rook discards Mgr SeviceMonitor monitoring labels when active manager reelected #14477

arttor opened this issue Jul 22, 2024 · 0 comments · Fixed by #14482
Labels

Comments

@arttor
Copy link
Contributor

arttor commented Jul 22, 2024

Is this a bug report or feature request?

  • Bug Report

Deviation from expected behavior:
After active manager reelected, rook removes monitoring labels from mgr ServiceMonitor.

Expected behavior:
After active manager reelected, mgr ServiceMonitor should keep all labels.

How to reproduce it (minimal and precise):

  1. Create Ceph Cluster with enabled monitoring and at least 2 managers:
spec:
  labels:
    monitoring:
      my-label: abc
  mgr:
    allowMultiplePerNode: true
    count: 2
    modules:
      - enabled: true
        name: rook
  monitoring:
    enabled: true
  1. Check that monitoring labels were propagated to mgr ServiceMonitor:
% kubectl -n rook-ceph get servicemonitor rook-ceph-mgr -o yaml | yq .metadata.labels
team: rook
my-label: abc
  1. Downscale active mgr (find one with metadata.label.mgr_role == active) and wait until remaining mgr will be labeled as active:
% kubectl -n rook-ceph scale deployment/rook-ceph-mgr-a --replicas=0
  1. Check that now mgr ServiceMonitor is missing monitoring labels:
% kubectl -n rook-ceph get servicemonitor rook-ceph-mgr -o yaml | yq .metadata.labels
team: rook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant