Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #6

Open
elfring opened this issue Dec 19, 2022 · 2 comments
Open

reserved identifier violation #6

elfring opened this issue Dec 19, 2022 · 2 comments

Comments

@elfring
Copy link

elfring commented Dec 19, 2022

I would like to point out that a prefix like “cmdf__” does eventually not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?
@ronen25
Copy link
Owner

ronen25 commented Dec 25, 2022

Hi @elfring, thank you for the comment.

The naming convention is indeed not very C friendly; it was done so because the library was meant to be used from C, and C support was only added afterwards.

Changing the naming convention to remove the cmdf__ prefix will break the C API, so I prefer not to do so, even at the expense of violating the standard's recommendations.

I am leaving this issue open, and any ideas will be greatly appreciated.

@elfring
Copy link
Author

elfring commented Dec 25, 2022 •
edited
Loading

…, so I prefer not to do so,

Double underscores may be used at some places also for C identifiers.

even at the expense of violating the standard's recommendations.

💭 Should such an implementation detail be reconsidered any more if questionable identifiers might be reused also for C software components?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @ronen25