You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a draft to showcase that we should gracefully shutdown the app-servers when we receive unexpected errors. I'm not that experienced when it comes to go-routines so this will probably not the final solution. The thing here is that we have to get that right. If we have uncoordinated fails like that, users will lose trust in the solution.
Proposal:
Integrate a graceful error handling that will cleanup and stop all services that templier started
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bastianwegge
changed the title
This is just a draft to showcase that we should gracefully shutdown the app-servers when we receive unexpected errors. I'm not that experienced when it comes to go-routines so this will probably not the final solution. The thing here is that we have to get that right. If we have uncoordinated fails like that, users will lose trust in the solution.
Proposal: