Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden rbx_reflector against unknown data types #403

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Harden rbx_reflector against unknown data types #403

merged 6 commits into from
Mar 29, 2024

Conversation

kennethloeffler
Copy link
Member

Today I noticed that rbx_reflector generate failed to output a database due to a new datatype:

     Running `target/debug/rbx_reflector generate rbx_reflection_database/database.msgpack rbx_dom_lua/src/database.json --patches patches`
[INFO  rbx_reflector::cli::defaults_place] Installing Studio plugin
[INFO  rbx_reflector::cli::defaults_place] Starting Roblox Studio...
[INFO  rbx_reflector::cli::defaults_place] Waiting for Roblox Studio to re-save place...
[INFO  rbx_reflector::cli::defaults_place] Uninstalling Studio plugin
Please save the opened place in Roblox Studio (ctrl s).
[INFO  rbx_reflector::cli::defaults_place] Place saved, killing Studio...
Error: Unknown type Path2DControlPoint

This got me thinking about how rbx_reflector can more gracefully deal with unknown data types. I intuit that we only need to care about unknown data types if they serialize. With this in mind, this PR makes rbx_reflector generate only bail on unknown serializable data types (with the exception of QDir and QFont - see comments).

@Dekkonot Dekkonot merged commit c8ec8a9 into rojo-rbx:master Mar 29, 2024
2 checks passed
@kennethloeffler kennethloeffler deleted the rbx-reflector-better-unimplemented-data-type-handling branch March 29, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dekkonot Dekkonot Dekkonot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kennethloeffler @Dekkonot