Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #6987 #7055

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix #6987 #7055

merged 3 commits into from
Sep 4, 2024

Conversation

Anton-4
Copy link
Collaborator

@Anton-4 Anton-4 commented Sep 3, 2024

No description provided.

@Anton-4
fix #6987
f89f2e8 
Signed-off-by: Anton-4 <17049058 [email protected]>
@Anton-4
Copy link
Collaborator Author

Anton-4 commented Sep 3, 2024 •
edited
Loading

perhaps I should add a println!("Error {:?}", std::io::Error::last_os_error()); in that branch as well

Edit: from the test failures it looks like it is working pretty well

@Anton-4 Anton-4 changed the title fix #6987 WIP fix #6987 Sep 3, 2024
@Anton-4
skip nonnullable_unwrapped
5b202d3 
See #5924 for context

Signed-off-by: Anton-4 <17049058 [email protected]>
@Anton-4
add nullable_unwrapped to exceptions
69bbcfe 
Signed-off-by: Anton-4 <17049058 [email protected]>
@Anton-4 Anton-4 changed the title WIP fix #6987 fix #6987 Sep 4, 2024
@Anton-4 Anton-4 merged commit 00572cb into main Sep 4, 2024
18 checks passed
@Anton-4 Anton-4 deleted the fix-roc-dev-hiding branch September 4, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Anton-4