Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Full from fmt to parse and reorganize confusingly-named Module ast type #6973

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Move Full from fmt to parse and reorganize confusingly-named Module ast type #6973

merged 1 commit into from
Aug 10, 2024

Conversation

joshuawarner32
Copy link
Collaborator

Module, where it was used, is now simply replaced by SpacesBefore<"a, Header<"a>> - which is fundamentally all it was before.

smores56
smores56 approved these changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@smores56 smores56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I"m not a huge fan of the struct being named Full and would prefer something requiring less context to understand (maybe FullAst?), but otherwise this is a good cleanup change.

@smores56 smores56 merged commit 3f7f189 into roc-lang:main Aug 10, 2024
18 checks passed
@joshuawarner32
Copy link
Collaborator Author

FullAst is fine by me!

@joshuawarner32 joshuawarner32 mentioned this pull request Aug 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smores56 smores56 smores56 approved these changes

@lukewilliamboswell lukewilliamboswell Awaiting requested review from lukewilliamboswell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuawarner32 @smores56