WIP replace cli flag --prebuilt-platform with --build-host
#6859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Architecture::Aarch32 => "aarch32", | ||
| Architecture::Aarch64 => "aarch64", | ||
| Architecture::Aarch32 => "arm", | ||
| Architecture::Aarch64 => "arm64", |
There was a problem hiding this comment.
Looking at rust and zig targets, I think this should be changed to aarch64 to be consistent with those toolchains.
This will be a breaking change for platforms that have prebuilt binaries.
lukewilliamboswell
force-pushed
the
rebuild-platform
branch
from
cd13762
to
8383fd6
Compare
lukewilliamboswell
force-pushed
the
rebuild-platform
branch
from
4521f92
to
85447ec
Compare
| let platform_main_roc = match &loaded.entry_point { | ||
| EntryPoint::Executable { platform_path, .. } => platform_path.to_path_buf(), | ||
| _ => unreachable!(), | ||
| }; | ||
|
|
||
| // For example, if we're loading the platform from a URL, it's automatically prebuilt | ||
| // even if the --prebuilt-platform CLI flag wasn't set. | ||
| let is_platform_prebuilt = prebuilt_requested || loaded.uses_prebuilt_platform; |
There was a problem hiding this comment.
I should add a check here; if loaded.uses_prebuilt_platform is true and also build_host_requested then the platform is a URL release and we have also been instructed to rebuild the host with the flag --build-host. These two are incompatible because roc cannot build the host.
|
|
||
| // file name for a stubbed app dynamic library file | ||
| pub fn stub_app_lib_file_name(&self) -> String { | ||
| format!("libapp.{}", self.dynamic_library_file_ext()) |
There was a problem hiding this comment.
On Windows I think it may just be app.dll, on unix* systems we need the lib prepended
This was referenced Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #6808, which should be merge first.
This PR makes progress towards decoupling roc from the host toolchains, by moving host rebuilding behind a compiler flag so it is no longer the default behaviour. It is still available where required using
--build-hosthowever will give a warning;I was originally working towards removing rebuilding in one go in #6696, however I realised this was a very large and difficult change due to the need to change all of the cli tests.
This PR achieves the same effect, effectively removing platform rebuilding from the cli for end users -- while keeping the cli tests as they are. This enables the cli tests to be adapted one by one instead of all at once. Once all of the tests have a build script, host rebuilding functionality can be entirely removed along with the associated dependencies.
Application authors who use a platform release from a URL package are not affected by this change. These users will continue to use a prebuilt platform.
Platform authors need to include a build script in their platform to build host binaries. This change will make running platform example less convenient if they are not using a URL release, as the platform binaries will need to be built first in a separate step. For example this workflow;
roc build.rocusing host toolchain e.g.cargoorzigroc examples/hello-world.roc