Add Task as a built-in module/type #6836

smores56 · 2024-06-25T07:34:08Z

This change moves the Task opaque IO type from platform-specific implementations to the standard library of Roc. This PR is ready for review, barring final testing by building a pre-release of basic-cli using the twin basic-cli PR. The high level changes are:

Copied the Task module from the basic-cli platform to crates/compiler/builtins/roc/Task.roc
Consolidated Task and Effect into just the Task opaque type with definition Task ok err := {} -> Result ok err, which is the old type for Effect a : {} -> a that Task ok err : Effect (Result ok err) wrapped
Removed the Effect generation code, as everything should use Task directly
- This includes the generates Effect with [after, map, ...] clause of the hosted module header, which is a breaking change
- FFI definitions on the host side need to return RocResults now, and FFI type declarations on the Roc side need to always have Task return types
- Removed generation of the Effect.after, Effect.map, etc. functions as they were needed to glue Effect to Task, but are no longer needed now that those types have been combined
Renamed hosted modules that contain FFI Roc declarations from Effect.roc to PlatformTask.roc to distinguish their behavior from the old approach and to give a name more descriptive of the new behavior
Updated almost of the testing, but until basic-cli works, that is on hold

crates/compiler/can/src/task_module.rs

lukewilliamboswell · 2024-07-19T10:52:00Z

It looks like there is a genuine issue with the False interpreter.

(nix:nix-shell-env) 192-168-1-103:false-interpreter luke$ roc build False.roc
🔨 Rebuilding platform...
0 errors and 0 warnings found in 940 ms
 while successfully building:

    False
(nix:nix-shell-env) 192-168-1-103:false-interpreter luke$ ./False examples/sqrt.false
Ran into problem:
examples/sqrt.false

ageron · 2024-07-29T09:23:15Z

Task.sequence runs tasks in reverse order, please see roc-lang/basic-cli#235

examples/cli/false-interpreter/platform/PlatformTask.roc

crates/cli/tests/benchmarks/platform/PlatformTasks.roc

examples/cli/effects-platform/PlatformTasks.roc

sort.roc

Anton-4

The sort.roc file is the only thing that needs to be addressed/clarified, all good for the rest 🎉

Anton-4 · 2024-08-28T14:36:24Z

I"m hitting some issues with d3732b4:

❯ ./target/release/roc crates/cli/tests/benchmarks/testAStar.roc 

── NAMING PROBLEM in crates/cli/tests/benchmarks/testAStar.roc ─────────────────

This annotation does not match the definition immediately following
it:

6│>  main : Task {} []
7│>  main =
8│>      PlatformTasks.putLine (showBool test1)
9│>          |> Task.mapErr! \_ -> crash "unreachable"

Is it a typo? If not, put either a newline or comment between them.


── UNRECOGNIZED NAME in crates/cli/tests/benchmarks/testAStar.roc ──────────────

Nothing is named `#!1_expr` in this scope.

8│>      PlatformTasks.putLine (showBool test1)
9│>          |> Task.mapErr! \_ -> crash "unreachable"

Did you mean one of these?

    Integer
    Hasher
    Box
    Signed16

────────────────────────────────────────────────────────────────────────────────

2 errors and 3 warnings found in 16 ms
.

You can run the program anyway with roc run crates/cli/tests/benchmarks/testAStar.roc

After I removed the type annotation on main, I hit:


roc on  builtin-task is 📦 v0.0.1 via 🦀 v1.77.2 via ❄  impure (nix-shell-env) 
❯ ./target/release/roc crates/cli/tests/benchmarks/testAStar.roc 
🔨 Rebuilding platform...
True
Roc standard library crashed with message

    voided tag constructor is unreachable

Shutting down

I tired several things without success, I"m going to revert the last commit for now.

This reverts commit d3732b4.

Anton-4 · 2024-08-28T17:43:26Z

Currently stuck on:

❯ ./target/release/roc examples/cli/false-interpreter/False.roc examples/cli/false-interpreter/examples/sqrt.false 
🔨 Rebuilding platform...
memory allocation of 93824993832009 bytes failed

This is the only remaining test failure (when doing cargo test --release).

Anton-4 · 2024-08-28T18:08:01Z

Lol, the valgrind errors:

==217577== ERROR SUMMARY: 2963963 errors from 128 contexts (suppressed: 0 from 0)

Anton-4 · 2024-08-28T18:29:02Z

I can continue investigating on Friday.
If anyone else wants to take a stab; I recommend stepping through the False executable with IDA free, side-by-side with the version on main.

smores56 · 2024-08-30T02:55:33Z

We reduced all tests failures down to the same issue. After removing unsized tasks from the false-interpreter platform (the platform of the failing test), we still got a failure. Namely, the host returns Ok(0), but Roc receives a Err {}, and we crash. The generated LLVM seems correct, so we are under the assumption that there is some lambda set issue here. The test has been therefore disabled for now, and we plan to revisit this once the lambda set fix is introduced.

If all tests pass, I vote that we call this good and merge, but I leave the final call to you @Anton-4.

Anton-4 · 2024-08-30T13:37:42Z

All tests should pass now 🤞

Anton-4

🎉

Add Task as a built-in module/type

700c7ae

smores56 marked this pull request as draft June 25, 2024 07:35

smores56 mentioned this pull request Jun 25, 2024

Add Task as a builtin module/type roc-lang/basic-cli#217

Merged

smores56 commented Jun 25, 2024

View reviewed changes

crates/compiler/can/src/task_module.rs Outdated Show resolved Hide resolved

smores56 commented Jun 25, 2024

View reviewed changes

crates/compiler/can/src/task_module.rs Outdated Show resolved Hide resolved

smores56 added 4 commits June 26, 2024 02:34

Fix generated type for foreign-call task wrappings

4b7d9c9

Fix all tests that don"t depend on basic-cli

5ea6a8b

Fix clippy errors

43fadea

Merge branch "main" into builtin-task

cd48830

smores56 force-pushed the builtin-task branch from c116b74 to cd48830 Compare June 26, 2024 10:18

lukewilliamboswell added 3 commits July 1, 2024 12:15

use basic-ssg 0.2.0 for roc website

66463c5

update tutorial

51104a6

add Task to list of builtins in tutorial, add links to docs

9b63856

lukewilliamboswell mentioned this pull request Jul 1, 2024

Add Task as a builtin module/type roc-lang/basic-webserver#58

Merged

smores56 added 3 commits July 3, 2024 00:42

Merge branch "main" into builtin-task

f61b303

Merge branch "main" into builtin-task

6f5f5f4

Merge branch "main" into builtin-task

682942f

ostcar mentioned this pull request Jul 9, 2024

Task as builtin lukewilliamboswell/roc-platform-template-go#4

Closed

kdziamura mentioned this pull request Jul 16, 2024

Type annotations for suffixed sugar #6868

Merged

lukewilliamboswell added 2 commits July 19, 2024 19:51

Merge remote-tracking branch "remote/main" into builtin-task

b489c44

replace with local paths for basic-cli

c6d2cfb

smores56 and others added 4 commits July 26, 2024 07:52

Merge branch "main" into builtin-task

d277bd9

Merge remote-tracking branch "remote/main" into builtin-task

eca453d

Merge remote-tracking branch "smores56/builtin-task" into builtin-task

062bc88

generates and generates_with fields removed from HostedHeader

4a5c00e

fix order of Task.sequence

aabe75f

lukewilliamboswell mentioned this pull request Jul 29, 2024

Task.sequence runs the tasks in reverse order roc-lang/basic-cli#235

Closed

This comment was marked as outdated.

Sign in to view

Anton-4 self-assigned this Aug 21, 2024

lukewilliamboswell added 2 commits August 22, 2024 10:06

Merge remote-tracking branch "remote/main" into builtin-task

d77ce4f

Merge remote-tracking branch "remote/main" into builtin-task

10241b3

bhansconnect reviewed Aug 24, 2024

View reviewed changes

examples/cli/false-interpreter/platform/PlatformTask.roc Outdated Show resolved Hide resolved

lukewilliamboswell and others added 2 commits August 26, 2024 05:55

Merge remote-tracking branch "remote/main" into builtin-task

6db429f

Pluralize PlatformTasks module

79cfcb0

Anton-4 reviewed Aug 26, 2024

View reviewed changes

crates/cli/tests/benchmarks/platform/PlatformTasks.roc Show resolved Hide resolved

Anton-4 reviewed Aug 26, 2024

View reviewed changes

examples/cli/effects-platform/PlatformTasks.roc Show resolved Hide resolved

Anton-4 reviewed Aug 26, 2024

View reviewed changes

sort.roc Outdated Show resolved Hide resolved

Anton-4 requested changes Aug 26, 2024

View reviewed changes

Anton-4 removed their assignment Aug 26, 2024

Avoid defining unsized platform Tasks

d3732b4

Anton-4 previously approved these changes Aug 27, 2024

View reviewed changes

Revert "Avoid defining unsized platform Tasks"

ca7d1cb

This reverts commit d3732b4.

Anton-4 dismissed their stale review via ca7d1cb August 28, 2024 14:37

Anton-4 added 2 commits August 28, 2024 16:38

remove sort.roc

c897f5e

basic-cli 0.15, test fixes

7938e4b

smores56 added 4 commits August 29, 2024 18:42

Use HashMap to store false-interpreter files

74f9b99

Merge branch "main" into builtin-task

e310ba8

Fix discordant u8 and u64 types

9263986

Ignore false-interpreter test, unrelated issue

3f866d9

Anton-4 mentioned this pull request Aug 30, 2024

Lower module params #7009

Merged

11 tasks

Anton-4 approved these changes Aug 30, 2024

View reviewed changes

Anton-4 merged commit e619f60 into roc-lang:main Aug 30, 2024
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Task as a built-in module/type #6836

Add Task as a built-in module/type #6836

smores56 commented Jun 25, 2024 •

edited

Loading

lukewilliamboswell commented Jul 19, 2024

ageron commented Jul 29, 2024

This comment was marked as outdated.

Anton-4 left a comment •

edited

Loading

Anton-4 commented Aug 28, 2024

Anton-4 commented Aug 28, 2024 •

edited

Loading

Anton-4 commented Aug 28, 2024

Anton-4 commented Aug 28, 2024

smores56 commented Aug 30, 2024

Anton-4 commented Aug 30, 2024

Anton-4 left a comment

Add Task as a built-in module/type #6836

Add Task as a built-in module/type #6836

Conversation

smores56 commented Jun 25, 2024 • edited Loading

lukewilliamboswell commented Jul 19, 2024

ageron commented Jul 29, 2024

This comment was marked as outdated.

Anton-4 left a comment • edited Loading

Choose a reason for hiding this comment

Anton-4 commented Aug 28, 2024

Anton-4 commented Aug 28, 2024 • edited Loading

Anton-4 commented Aug 28, 2024

Anton-4 commented Aug 28, 2024

smores56 commented Aug 30, 2024

Anton-4 commented Aug 30, 2024

Anton-4 left a comment

Choose a reason for hiding this comment

smores56 commented Jun 25, 2024 •

edited

Loading

Anton-4 left a comment •

edited

Loading

Anton-4 commented Aug 28, 2024 •

edited

Loading