infer for a proc whether it is OK to pass an argument as borrowed #6585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this only looks at calls to lowlevels right now, not calls to other functions
rtfeldman
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is not actually hooked up
there are also these limits
List *andStrlayouts, or lambda sets containing just those layoutsthe next step is to walk the topological sort of procs and for each SCC run this inference until fixpoint. At that point we can call other (user) functions and pass arguments as borrowed. I'm not sure yet if we need to change something about functions themselves when one of the arguments is passed to it as borrowed. I suspect we do which means more thinking is required