Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-PACertificate redownloads completed certs if run again with same arguments #9

Closed
rmbolger opened this issue May 3, 2018 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rmbolger
Copy link
Owner

rmbolger commented May 3, 2018

New-PACertificate is written in such a way that if the cert request process has an error or is otherwise interrupted prior to completing the request, you can run the same command again and it will attempt to pick up where it left off.

Currently if request makes it all the way to completion, running the same command again will re-download and overwrite the cert files each time it's run until the renewal window.

It should probably just do nothing instead. Maybe throw a warning that the order is already complete and to use -Force if you want to re-issue.

@rmbolger rmbolger self-assigned this May 3, 2018
@rmbolger rmbolger added the bug Something isn't working label May 3, 2018
@rmbolger rmbolger closed this as completed May 4, 2018
rmbolger added a commit that referenced this issue May 6, 2018
@rmbolger rmbolger modified the milestones: v1.2, v2.0 May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant