Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OVH plugin using DnsAlias fails if not using subdomain of the OVHdomain #535

Closed
ctdml opened this issue Feb 6, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@ctdml
Copy link

ctdml commented Feb 6, 2024

To me it apperas that the TXT chalange entries cant be added to the OVHdomain directly, but must be added to a subdomain of the OVHdomain (so same zone file) which is the workaround for me. The below error gets thrown if not using a subdomain as DnsAlias. My understanding is that in this situation $recShort beeing empty is correct, but the function cant handle this.

Thanks a lot for providing Posh-ACME and its DNS plugins!
Best Regards

Submit-ChallengeValidation -verbose
AUSFÜHRLICH: Publishing challenge for Domain one.company.eu with Token
XXXXXXXXXXXXXXXXXXXXXXXXXX using Plugin OVH and DnsAlias 'company.provider.eu'.
AUSFÜHRLICH: CTEDML, first command in Add-DnsTXT in Plugin
AUSFÜHRLICH: CTEDML, next is find-ovhdomain in Plugin for company.provider.eu
AUSFÜHRLICH: CTEDML, OVHDomain is company.provider.eu
AUSFÜHRLICH: CTEDML, recShort is
Submit-ChallengeValidation : Das Argument kann nicht an den Parameter "RecordShort" gebunden werden, da es sich um
eine leere Zeichenfolge handelt.
In Zeile:1 Zeichen:1
  Submit-ChallengeValidation -verbose
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  CategoryInfo          : InvalidData: (:) [Submit-ChallengeValidation], ParameterBindingValidationException
  FullyQualifiedErrorId : ParameterArgumentValidationErrorEmptyStringNotAllowed,Submit-ChallengeValidation   
@rmbolger rmbolger self-assigned this Feb 6, 2024
@rmbolger rmbolger added the bug Something isn't working label Feb 6, 2024
@rmbolger
Copy link
Owner

rmbolger commented Mar 8, 2024

Hi @ctdml. So sorry for the delayed response on this. You are entirely correct. This is a bug with an internal function not allowing for an empty subdomain. I'm in the process of pushing a fix right now.

rmbolger added a commit that referenced this issue Mar 8, 2024
@rmbolger
Copy link
Owner

rmbolger commented Mar 9, 2024

Fix is live in 4.21.0

@rmbolger rmbolger closed this as completed Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants