Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNSPlugin for Cloudflare #14

Closed
rian-hout opened this issue May 9, 2018 · 3 comments
Closed

DNSPlugin for Cloudflare #14

rian-hout opened this issue May 9, 2018 · 3 comments
Labels
enhancement New feature or request
Milestone
v2.0

Comments

@rian-hout
Copy link
Contributor

I wrote a DNSPlugin for Cloudflare. I'm having trouble make a pull request to upload the file. I'm receiving a permissions error. Can you help with this?
@rmbolger
Copy link
Owner

rmbolger commented May 9, 2018 •
edited
Loading

First off, thanks! CloudFlare support will be a great addition.

Did you fork this project into your own GitHub profile and make changes to the fork? Or did you just clone this project directly and make changes there?

If it was the latter, the problem is that you don't have access to push changes directly into this repository. Here's a decent guide on contributing to a project on GitHub.
https://akrabat.com/the-beginners-guide-to-contributing-to-a-github-project/

If you're getting a permissions error uploading to your own fork, I have no clue what might be wrong. You might need to contact GitHub support.

@rian-hout
Copy link
Contributor Author

I just did a fork and created a pull request.

@rmbolger rmbolger mentioned this issue May 9, 2018
Merged
@rmbolger rmbolger added this to the v1.2 milestone May 11, 2018
@rmbolger rmbolger added the enhancement New feature or request label May 11, 2018
rmbolger pushed a commit that referenced this issue May 12, 2018
@rian-hout @rmbolger
Cloudflare DNS Plugin (#15)
b0e8f56 
* added Cloudflar DNS plugin and readme for issue #14
@rmbolger
Copy link
Owner

This is now in the master branch and will be included in the next release.

@rmbolger rmbolger modified the milestones: v1.2, v2.0 May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
2 participants
@rmbolger @rian-hout