Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for horizontal scrolling to List #513

Closed
wants to merge 1 commit into from

Conversation

tslocum
Copy link
Contributor

@tslocum tslocum commented Oct 13, 2020

Resolves #512.

This change is available in cview, a fork of tview.

@abitrolly
Copy link
Contributor

Is there an indicator that a column is scrolled?

@tslocum
Copy link
Contributor Author

tslocum commented Oct 31, 2020

No horizontal indicator is drawn. I suggested changes adding vertical scroll indicators in January, which could be adapted for this.

@abitrolly
Copy link
Contributor

@tslocum maybe it is possible to modify List to be easier extendable to add these features in custom UI rather than patching and maintaining custom version of tview?

@tslocum
Copy link
Contributor Author

tslocum commented Oct 31, 2020

Please see this document for an explanation of why I forked tview and the differences between the two.

@rivo
Copy link
Owner

rivo commented Feb 14, 2021

@tslocum Just curious, have you tried this with multi-rune Unicode characters or even with characters that occupy more than one cell?

@rivo rivo closed this in dfabe78 Feb 15, 2021
@rivo
Copy link
Owner

rivo commented Feb 15, 2021

Well, the proper solution took me a few hours to figure out. It"s not as easy as it may have seen because, as in many other places,

byte ≠ rune ≠ Unicode character

So I can"t merge this PR. Sooner or later someone gets problems with emojis or foreign characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizonal scroll for List
3 participants