Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing selection on a cleared table can make the app unresponsive. #944

Closed
stijnveenman opened this issue Feb 5, 2024 · 2 comments
Closed

Changing selection on a cleared table can make the app unresponsive. #944

stijnveenman opened this issue Feb 5, 2024 · 2 comments

Comments

@stijnveenman
Copy link

If we take the following example

package main

import (
	"github.com/gdamore/tcell/v2"
	"github.com/rivo/tview"
)

func main() {
	app := tview.NewApplication()
	table := tview.NewTable().
		SetBorders(true)

	table.SetCell(0, 0, tview.NewTableCell("test").SetSelectable(false))
	table.SetCell(1, 0, tview.NewTableCell("test").SetSelectable(true))
	table.SetCell(2, 0, tview.NewTableCell("test").SetSelectable(true))

	table.SetSelectable(true, false)

	table.SetInputCapture(func(event *tcell.EventKey) *tcell.EventKey {
		if event.Rune() == 'a' {
			table.SetCell(table.GetRowCount(), 0, tview.NewTableCell("test"))
		}
		if event.Rune() == 'c' {
			table.Clear()
			table.SetCell(0, 0, tview.NewTableCell("test").SetSelectable(false))
		}
		return event
	})

	if err := app.SetRoot(table, true).SetFocus(table).Run(); err != nil {
		panic(err)
	}
}

We have row 0; which is not selectable (think of a header in a table)
And a few selectable rows. We can add rows by pressing a, and clear with c.

Expected

If we add a few rows this works fine, but if we click c we clear the table and create the (unselectable) header again. Then, we press j to move to a different row, causing the selection to "change".

After this, the app becomes unresponsive. Adding a new row with a does nothing.
Even ctr c does not close the app anymore, and CPU jumps up to 100%.

Side note: if i clear the table with row 2 (3th row) selected, and do not select a different row. And add a few rows again, i can see that row 2 is still selected. And the app stays responsive. It only happens when changing a row.
@stijnveenman stijnveenman mentioned this issue Feb 5, 2024
Merged
@F1bonacc1
Copy link

I attached a goroutine profiler. It looks like the table is stuck in this loop:

tview/table.go

Line 1373 in 861aa94

for { 

#	0x65ae14	github.com/rivo/tview.(*Table).InputHandler.func1.2 0x54			github.com/rivo/[email protected]/table.go:1375
#	0x65aca3	github.com/rivo/tview.(*Table).InputHandler.func1.5 0xa3			github.com/rivo/[email protected]/table.go:1440
#	0x65a5a4	github.com/rivo/tview.(*Table).InputHandler.func1 0x4e4				github.com/rivo/[email protected]/table.go:1598
#	0x65a08f	github.com/rivo/tview.(*Table).InputHandler.(*Box).WrapInputHandler.func2 0x4f	github.com/rivo/[email protected]/box.go:167
#	0x63bb16	github.com/rivo/tview.(*Grid).InputHandler.func1 0x1b6				github.com/rivo/[email protected]/grid.go:277
#	0x63b92f	github.com/rivo/tview.(*Grid).InputHandler.(*Box).WrapInputHandler.func2 0x4f	github.com/rivo/[email protected]/box.go:167
#	0x650801	github.com/rivo/tview.(*Pages).InputHandler.func1 0xa1				github.com/rivo/[email protected]/pages.go:311
#	0x65072f	github.com/rivo/tview.(*Pages).InputHandler.(*Box).WrapInputHandler.func2 0x4f	github.com/rivo/[email protected]/box.go:167
#	0x627737	github.com/rivo/tview.(*Application).Run 0x557

@rivo rivo closed this as completed in e350bef Mar 7, 2024
@rivo
Copy link
Owner

rivo commented Mar 7, 2024

Thank you. This should be fixed with the latest commit.

kopecmaciej pushed a commit to kopecmaciej/tview that referenced this issue Aug 27, 2024
@rivo @kopecmaciej
Fixed an infinite loop after clearing a selected cell. Fixes rivo#944
68f3979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rivo @F1bonacc1 @stijnveenman