Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in TextView demo: no highlighted regions in view #941

Closed
ok-go opened this issue Jan 19, 2024 · 1 comment
Closed

Bug in TextView demo: no highlighted regions in view #941

ok-go opened this issue Jan 19, 2024 · 1 comment

Comments

@ok-go
Copy link

ok-go commented Jan 19, 2024 •
edited
Loading

First case:
Run demo -> Press Enter.
Expected: first region highlighted.
Actual: nothing happens

Second case:
Run demo -> Click on to first region -> First region highlighted -> Press Tab
Expected: jump to next region
Actual: highlights disappeared

Bug is reproduced in both cases when text fits into the view and doesn't.

Fix in demo: remove ScrollToHighlight call or disable scrolling on TextView

tview version: 742cf08
macOS: 14.1.1
app: iTerm2
@rivo rivo closed this as completed in 7568c3f Jan 20, 2024
@rivo
Copy link
Owner

rivo commented Jan 20, 2024

Thanks for notifying me of this. I made a mistake in a commit yesterday. This should be fixed now.

kopecmaciej pushed a commit to kopecmaciej/tview that referenced this issue Aug 27, 2024
@rivo @kopecmaciej
Fixed disappearing highlights. Fixes rivo#941
1170a87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rivo @ok-go