Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] logs in ui #573

Open
dzfranklin opened this issue Aug 30, 2024 · 1 comment
Open

[feature request] logs in ui #573

dzfranklin opened this issue Aug 30, 2024 · 1 comment

Comments

@dzfranklin
Copy link

I would like to see logs emitted by a job in a pane in the UI alongside the errors and so on.

I think this could be implemented by storing a slog logger in the context and providing a helper to retrive it. Of course this would only work with applications structured around an explicit non-global logger. Probably you'd also want to limit the max log size to avoid disk space issues?

I'm aware this would be a bunch of work and isn't essential but I think it'd be useful.

@brandur
Copy link
Contributor

brandur commented Aug 31, 2024

Spoke to @bgentry about this one. I think we're both on board in that this would be a cool feature, but we want to make sure it's flexible enough to cover all kinds of set ups, and that's a little non-trivial. For example, especially for a larger operation, it's not a particularly good idea to store logs directly in the database, so we'd want to have some way for those users to specify some kind of "fetch hook" that'd be able to reach out and pull logs for a job from the right place to show them inline with the UI.

There should probably be a simple version too that provides an option to put logs into metadata or something for easy out-of-the-box use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants