Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cargo.lock #151

Merged
merged 1 commit into from
May 28, 2024
Merged

Update Cargo.lock #151

merged 1 commit into from
May 28, 2024

Conversation

huajingyun01
Copy link
Contributor

Upgrade libc to v0.2.155 to support LoongArch64.

Update libc to 0.2.155.

Release notes :https://github.com/rust-lang/libc/releases

@riquito
Copy link
Owner

riquito commented May 28, 2024

@huajingyun01 why do you need the latest libc? Which platform are you running tuc on?

@huajingyun01
Copy link
Contributor Author

@huajingyun01 why do you need the latest libc? Which platform are you running tuc on?

Hi @riquito I had to update libc to 0.2.155 to support LoongArch64, because tuc compilation based on musl LoongArch64 failed.
rust-lang/libc#3606

Thanks.

@riquito
Copy link
Owner

riquito commented May 28, 2024

I see you opened the same PR on many repositories, could you explain me why?

@riquito
Copy link
Owner

riquito commented May 28, 2024

Closing this PR because it's suspicious and not in good faith.

The author is either a bot or act like one, it's a new account perhaps farming reputation or trying to achieve some number of PRs merged.
It keeps creating the same PR using slightly different titles, always replying with the same sentence.

Here follow the list of the PRs opened so far

sd
chmln/sd#300

sccache
mozilla/sccache#2188

tokei
XAMPPRocky/tokei#1104

topgrade (merged)
topgrade-rs/topgrade#818

typst
typst/typst#4268

tuc
#151

rav1e
xiph/rav1e#3378

wluma (merged)
maximbaz/wluma#107

zoxide (merged)
ajeetdsouza/zoxide#817

xh (merged)
ducaale/xh#367

wayshot
waycrate/wayshot#117

websocat
vi/websocat#241

@huajingyun01
Copy link
Contributor Author

I see you opened the same PR on many repositories, could you explain me why?

Yes, I am working on the Alpine Linux LoongArch64 port. During this process, I found that a large number of software failed to compile due to low libc versions(loongarch64 architecture support is not added to src/unix/linux_like/linux/musl).

Libc supports musl loongarch64 starting from 0.2.154, and the latest version is 0.2.155.

Therefore I want to submit this PR for repositories that haven't upgraded libc yet.It would be great if the upstream of the involved repositories could upgrade libc.

Thanks.

@huajingyun01
Copy link
Contributor Author

Hi @riquito

I'm sorry that my lack of detailed explanation caused trouble to you. I will update the comments for all other PRs.

I started pushing the LoongArch64 port on alpine last year: https://gitlab.alpinelinux.org/alpine/tsc/-/issues/72

Can you reopen this PR?
Thank you.

@riquito riquito reopened this May 28, 2024
@riquito
Copy link
Owner

riquito commented May 28, 2024

Hi @huajingyun01 ,
sorry for doubting you, reading the comments on the sccache repo and your reply it looks like your efforts are genuine.

The PR looks good, going to merge

@riquito riquito merged commit 47c25a5 into riquito:master May 28, 2024
2 checks passed
@huajingyun01
Copy link
Contributor Author

Hi @huajingyun01 , sorry for doubting you, reading the comments on the sccache repo and your reply it looks like your efforts are genuine.

The PR looks good, going to merge

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants