Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert back to using Arc::ptr_eq in verifier #26

Closed
rib opened this issue Dec 14, 2022 · 0 comments · Fixed by #29
Closed

Revert back to using Arc::ptr_eq in verifier #26

rib opened this issue Dec 14, 2022 · 0 comments · Fixed by #29

Comments

@rib
Copy link
Owner

rib commented Dec 14, 2022

Since the libs team recently agreed that they would update the implementation of Arc::ptr_eq to ignore meta data associated with the inner value then we can revert to using Arc::ptr_eq here:

// WARNING:

Even before the implementation is changed we can simply ignore the clippy warning since there's no risk of meta data affecting our specific use case anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant