Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhai no_std appears to rely on once_cell/alloc but does not request it #869

Open
cbiffle opened this issue May 5, 2024 · 3 comments
Open

Comments

@cbiffle
Copy link

cbiffle commented May 5, 2024

Hi! Playing with Rhai on no_std over here (on an actual platform that doesn't provide std).

Currently, 1.18.0 won't build on a platform that doesn't provide std, because it appears to be relying on the once_cell crate having the alloc feature set (to get once_cell::race::OnceBox), but isn't setting that feature itself -- at least when depended on as

rhai = { version = "1.18.0", default-features = false, features = ["no_std"] }

Adding a redundant dep to once_cell and setting the alloc feature in my build causes it to start working:

# TODO: had to add this because rhai isn't requesting a feature it relies on.
once_cell = { version = "1.19.0", default-features = false, features = ["alloc"] }
@cbiffle
Copy link
Author

cbiffle commented May 5, 2024

From the commit history it looks like this might be a known bug; might be worth adding something to the README that the packaged versions require this workaround, lest it trip up more people. Feel free to close if you feel it's fixed.

@schungx
Copy link
Collaborator

schungx commented May 6, 2024

Hhhmmm... that's strange, as the example under no_std has exactly the same default-features = false, features = ["no_std"] and it builds fine...

@schungx
Copy link
Collaborator

schungx commented Jul 6, 2024

@cbiffle do you have more info on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants