Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed 404 when checking for DO action too fast #1344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed 404 when checking for DO action too fast #1344

wants to merge 1 commit into from

Conversation

wolph
Copy link

@wolph wolph commented Apr 30, 2020

The Digital Ocean API isn't fast enough (consistently in my case). When attaching a volume the library checks for the action in the API too fast so DO returns a 404.

This fix assumes that the 404 is similar to other not-ready errors.

Example command that used to fail consistently for me:

rexray volume attach <volume>

Example log errors before:

time="2020-04-30T13:34:40Z" level=error msg="Error while waiting for storage action to finish" host="unix:///var/run/rexray.sock" inner="GET https://api.digitalocean.com/v2/volumes/<volume>/actions/<droplet>: 404 (request \"...\") could not get volume action: no volume event found" instanceID="dobs=...,name=docker-00&region=ams3" route=volumeAttach server=boom-scribe-cm service=dobs storageDriver=dobs task=0 time=1588253680334 tls=false txCR=... txID=... volumeID=...
time="2020-04-30T13:34:40Z" level=error msg="error: api call failed" error.volumeID=... host="unix:///var/run/rexray.sock" route=volumeAttach server=boom-scribe-cm time=1588253680334 tls=false txCR=... txID=...

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@3620358). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1344    /-   ##
=========================================
  Coverage          ?   34.25%           
=========================================
  Files             ?       36           
  Lines             ?     2362           
  Branches          ?        0           
=========================================
  Hits              ?      809           
  Misses            ?     1450           
  Partials          ?      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3620358...aab5a13. Read the comment docs.

This was referenced Feb 4, 2021
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wolph @CLAassistant @codecov-io