-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to report errors with custom errorformat #667
Labels
Comments
I'm guessing jsonlint and markdownlint output results to stderr instead of stdout, so the results are not piped to reviwedog. Can you confirm? |
Yes. $ markdownlint README.md
README.md:70 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
README.md:71 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 3]
README.md:72 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 4]
README.md:73 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 5]
README.md:74 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 6]
README.md:75 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 7]
README.md:76 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 8]
README.md:77 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 9]
README.md:78 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 10]
$ echo $?
1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running reviewdog with jsonlint:
./node_modules/.bin/jsonlint -q -c $i | ./reviewdog -efm="%f: line %l, col %c, %m" -name="json lint" -reporter=github-check -fail-on-error
No errors reported
Errorformat playground tells me my format is correct.
I checked with latest as well as nightly build but no luck.
Same issue happens with markdownlint
Errorformat playground
I had similar issue with docker lint but that got fixed with
-fail-on-error
I'm using pylama and yamllint - both with custom formats and they seem to work just fine, even without
-fail-on-error
. So I'm not sure what's going on.Here's my Github Actions script if that helps:
The text was updated successfully, but these errors were encountered: