-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reviewdog action-cpplint sample PR #2
base: master
Are you sure you want to change the base?
Conversation
@@ -13,9 14,24 @@ class Hoge | |||
int m_a; | |||
}; | |||
|
|||
// https://github.com/yohhoy/cpp-longest-identifier/wiki | |||
bool longest_identifier() | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
{ should almost always be at the end of the previous line [whitespace/braces] [4]
std::atomic<int> x(3); | ||
|
||
int expected = 3; | ||
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]
|
||
int expected = 3; | ||
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2, | ||
std::memory_order_acquire, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]
int expected = 3; | ||
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2, | ||
std::memory_order_acquire, | ||
std::memory_order_acquire); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]
std::memory_order_acquire, | ||
std::memory_order_acquire); | ||
|
||
std::cout << std::boolalpha << result << " " << x.load() << " " << expected << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]
std::atomic<int> x(3); | ||
|
||
int expected = 3; | ||
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]
|
||
int expected = 3; | ||
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2, | ||
std::memory_order_acquire, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]
int expected = 3; | ||
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2, | ||
std::memory_order_acquire, | ||
std::memory_order_acquire); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]
std::memory_order_acquire, | ||
std::memory_order_acquire); | ||
|
||
std::cout << std::boolalpha << result << " " << x.load() << " " << expected << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]
this is sample PR, do not merge.