fix(harfbuzz): uncouple from Skia #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That would be great, but not essential. I'm moving the examples back into the respective packages as well, and it would be nice to be able to work on harfbuzz without having to compile the monstrosity that is skia. |
glennsl
approved these changes
Jul 20, 2020
|
@glennsl sounds good, I can decouple them. It's not necessary for Harfbuzz to have font discovery. |
bryphe
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@glennsl mentioned in #927 that these two libraries should be separate, and I totally agree. This uncouples them completely, except for the examples/CI to get font discovery working. @glennsl, let me know if you want me to remove that as well.