Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(skia): bring back ASAN for SkiaFontManagerCli #961

Merged
merged 4 commits into from
Jul 17, 2020
Merged

chore(skia): bring back ASAN for SkiaFontManagerCli #961

merged 4 commits into from
Jul 17, 2020

Conversation

zbaylin
Copy link
Member

@zbaylin zbaylin commented Jul 17, 2020

Now that we have a way to suppress the fontconfig leaks, this should have leak detection. This will prevent future leaks from Skia in regards to the font manager.

@zbaylin zbaylin requested a review from bryphe July 17, 2020 14:49
@zbaylin zbaylin requested a review from glennsl July 17, 2020 15:09
bryphe
bryphe approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@bryphe bryphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - definitely makes sense to have this coverage so we can catch the leaks early. Thanks for thinking about this!

@zbaylin zbaylin merged commit 96c68b4 into master Jul 17, 2020
@Et7f3 Et7f3 deleted the chore/skia/font-manager-asan branch May 6, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryphe bryphe bryphe approved these changes

@glennsl glennsl Awaiting requested review from glennsl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zbaylin @bryphe