chore(deps): upgrade esy-harfbuzz to 2.6.8 #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bryphe those health checks we talked about -- did you want to bake those in here or in Oni? Let me know if here and I can make them part of this PR! |
|
@zbaylin - implementing them in Oni is fine! Here's where we'd add it: (Similar to the We'd just want to verify we get a valid version for both the 'compiled' harfbuzz version and the 'linked' harfbuzz version - so we might need to expose those as APIs on the reason side, is the only necessary addition. |
|
@bryphe Sounds good -- I added those version functions in the form of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves our dependency on esy-harfbuzz to our own version at 2.6.8.