Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dependency): bump esy-skia -> 66db8c5 #1073

Merged
merged 8 commits into from
May 30, 2021

Conversation

zbaylin
Copy link
Member

@zbaylin zbaylin commented May 25, 2021

This uses a prebuilt Skia DLL. The last successful CI build on Windows on master took 1hr10m, lets see how long this takes!

@zbaylin zbaylin requested a review from bryphe May 26, 2021 19:46
@zbaylin zbaylin changed the title refactor(dependency): bump esy-skia -> c648995 refactor(dependency): bump esy-skia -> 66db8c5 May 27, 2021
@zbaylin
Copy link
Member Author

zbaylin commented May 29, 2021

Looks like bumping the Ubuntu version on CI "fixed" the build error -- I think it might have had something to do with a bad cache. Regardless, it looks like this is ready now @bryphe !

Copy link
Member

@bryphe bryphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through the build issues! Tried it on Windows - works great 👍

@zbaylin zbaylin merged commit 79c2572 into master May 30, 2021
@Et7f3 Et7f3 deleted the refactor/dependency/esy-skia_c648995 branch May 30, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants